Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Add and AddAtFront handle multi element paths as strings #2220

Closed
rwmcintosh opened this issue Mar 22, 2024 · 0 comments · Fixed by #2221
Closed

Make Add and AddAtFront handle multi element paths as strings #2220

rwmcintosh opened this issue Mar 22, 2024 · 0 comments · Fixed by #2221
Assignees

Comments

@rwmcintosh
Copy link
Member

We keep creating new cases of the bug where we try to append a pathelement as a string and it gets added as a single entry, but it actually has the pipe separator in there.

The string overrides for adding elements to a path should handle the cases where the intention is to add a multi-part path rather than a single element. We just have to break it up by the PATH_DELIMITER

image

@rwmcintosh rwmcintosh added this to v12 Mar 22, 2024
@rwmcintosh rwmcintosh self-assigned this Mar 22, 2024
rwmcintosh added a commit that referenced this issue Mar 22, 2024
@rwmcintosh rwmcintosh mentioned this issue Mar 22, 2024
16 tasks
msevestre pushed a commit that referenced this issue Mar 22, 2024
* Fixes #2220

* remove unnecessary document lines

* PR feedback

* PR feedback

* pr feedback

* add some expression bodies

* fix failing tests.
@github-project-automation github-project-automation bot moved this to Fixed in v12 Mar 22, 2024
@Yuri05 Yuri05 moved this from Fixed to Verified in v12 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Verified
Development

Successfully merging a pull request may close this issue.

1 participant