Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x and y axis caption of importer graph misleading #2043

Closed
msevestre opened this issue Jun 22, 2023 · 4 comments · Fixed by #2062
Closed

x and y axis caption of importer graph misleading #2043

msevestre opened this issue Jun 22, 2023 · 4 comments · Fixed by #2062
Assignees

Comments

@msevestre
Copy link
Member

image

Can we have the x and y axis show the caption in the table instead of the dimension? (e,g PMA [years] and Ontogey Factor) instead of Dimensionless?

or is there a good reason for this mismatch?

@Yuri05
Copy link
Member

Yuri05 commented Jun 23, 2023

or is there a good reason for this mismatch?

I don't see any reason. The axis captions should be indeed those from the table.

@georgeDaskalakis
Copy link
Contributor

georgeDaskalakis commented Jun 23, 2023

@msevestre @Yuri05 and the dimension should be mentioned in parentheses, or not at all? Actually would make more sense mentioning the unit I guess....

@Yuri05
Copy link
Member

Yuri05 commented Jun 23, 2023

For the X-axis: yes. For Y: no. So in fact I would like to see exactly the same captions as in the table
grafik

(I think in general for any plots: if the axis dimension is dimensionless, it should not be displayed as part of the axis caption.)

@georgeDaskalakis
Copy link
Contributor

OK, so always display the caption, if not dimensionless also display the unit.

georgeDaskalakis added a commit that referenced this issue Jul 24, 2023
* 2043 fix

* code review correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants