plotIndividualTimeProfile and plotPopulationTimeProfile line type
#926
Comments
|
Please don't create new issues for this. All these points should be mentioned in the Discussion. |
|
I want to merge the PR ASAP and continue working on improvements in separate issues. In the discussion, there is no way to track what has been fixed. |
|
Discussion is not the right place to see what is implemented. It is the example plots in the PR, which are updated after each commit: https://github.com/Open-Systems-Pharmacology/OSPSuite-R/pull/871/files
|
|
Fixed in 0c213b7 |
|
It's absolutely ok to create issue for this. The PR can reference the issue |
|
We will just have to agree to disagree then. |
|
Yep. Just don't close the issue if someone takes the time to create them. Just reference it in your PR |
|
Yeah, but I am not ignoring them by closing them. I closed the issues and immediately created comments in the respective Discussion. Apologies to @PavelBal if he felt that I ignored his comments. Every new issue that is created with respect to the pending PR is a new thing for me to keep track of. I am currently juggling:
So the narrower the surface area we keep for specifications, the more probable it is that I don't miss something. |
* adds first drafts for plot config function + class > “I became insane, with long intervals of horrible sanity.” - Edgar Allan Poe * more aesthetics * cover more properties * remaining not necessary, or derivative of existing * docs * docs * fixes * remove unused parameters * Update DESCRIPTION * minor * use `LabelConfiguration` for labels * add background configuration * add an intermediary class this makes ospPlotConfig more general purpose class * Update plotIndividualTimeProfile.R * update * remove `createPlotConfiguration()` * use enums in docs * choose defaults * bump version of ospsuite.utils * minor * defaults for export * remove constructor; add aesthetics for annotations * rename the class; adapt everything for this change also change file names for this change * no constructor needed for internal class either * rename file * choosing defaults * minor * fix build failures * remaining substitutions * remove options that don't make sense * make the default `NULL` * remove unnecessary fields; catch up with tlf * more parameter cleanup * Use ospDefault color map * remove spurious parameter * fix alignment issues * non grouped datasets get their own grouping * fix color issue * choose better axes default labels * respect user defined color maps as well * reduce size of axes labels; add example * add NEWS; move tlf to Suggests * can't re-export & have tlf in Suggests same time cc @Yuri05 * re-export for now * more docs; tlf as hard dep; elementary class tests * add visual regression test * more enum; more tests * skip for now visual regression tests are fragile; need to know where the subtle differences are coming from * simplify updating legend data * first draft of `plotPopulationTimeProfile()` * minor cleanup * improve population profile plot * also anticipate only observed/simulated contexts * anticipate missing error unit column * support caption; try running tests on CI again * tests for `plotIndividualTimeProfile()` * test for `plotPopulationTimeProfile()` * skip population test on AppVeyor * no unit in axes labels when unitless * use helper to remove duplicated code * address more review comments * not necessary anymore * get rid of `DefaultInternalPlotConfiguration` * separate linetype per dataset * revert linetype change; anticipate other labels * set default aesthetic maps on plot-by-plot basis * closes #926 * docs * More docs * section for scaling * set tlf data to NULL when dataType isn't present * also update docs * Update plot-population-time-profile.R * add visual regression test for population profile * also test that changing linetypes works * more docs * extract out common plotting function Co-Authored-By: Pavel Balazki <pavel.balazki@gmail.com> Co-authored-by: Pavel Balazki <pavel.balazki@gmail.com>
Default line type should be "solid" and not "dashed".
The text was updated successfully, but these errors were encountered: