Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal characters in parameter/container names #530

Closed
Yuri05 opened this issue Mar 9, 2021 · 6 comments
Closed

Illegal characters in parameter/container names #530

Yuri05 opened this issue Mar 9, 2021 · 6 comments

Comments

@Yuri05
Copy link
Member

Yuri05 commented Mar 9, 2021

At the moment some illegal characters can be included into parameter names, which might lead to problems, e.g.

  • Double quotes
  • Pipes
  • ... (anything else?)

Naming check should be extended, so that those characters will be forbidden.

grafik

grafik

@msevestre
Copy link
Member

in MoBi there is absolutly no Name check
image

WHAT?!?

@PavelBal
Copy link
Member

in MoBi there is absolutly no Name check

But I think that a formula using such an "alias" would not work?

I can create a parameter 123, but in the formula the alias must be _123, otherwise an error in the equation field is shown.

@Yuri05
Copy link
Member Author

Yuri05 commented Mar 16, 2021

@PavelBal For a formula it's true, but it will crash elsewhere.
Try to create a simulation in this project: P1P2.zip 😉
grafik

@msevestre
Copy link
Member

Should not we simply disallow usage of all weird stuff like in PKSim and do if for ALL entities created from now on.
?

@Yuri05
Copy link
Member Author

Yuri05 commented Mar 16, 2021

Should not we simply disallow usage of all weird stuff like in PKSim and do if for ALL entities created from now on?

Would make sense :)

@msevestre
Copy link
Member

The base class in core already is like this
https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/blob/develop/src/OSPSuite.Presentation/DTO/NonEmptyNameDTO.cs#L26

Cleary Mobi does not use this

msevestre added a commit that referenced this issue Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants