Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.4.0 #162

Merged
merged 12 commits into from
Jan 21, 2025
Merged

Release v1.4.0 #162

merged 12 commits into from
Jan 21, 2025

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jan 5, 2025

Release v1.4.0 with the changes listed below.

I did all the changes without deep knowledge of R, so feel free to review and let me know if there's anything that could be improved.


Added

  • Support for the OpenID Connect Client Credentials flow
  • compute_result, create_job, update_job, create_service and update_service have an additional parameter to inject custom properties into the request (e.g., to set memory or CPU limits)
  • Implement the datacube subtype through the new DataCube class (which RasterCube and VectorCube inherit from now)

Changed

  • OpenID Connect scopes can be provided as lists

Fixed

  • describe_collection and collection_viewer accept string IDs again

@m-mohr m-mohr added this to the 1.4.0 milestone Jan 5, 2025
@m-mohr m-mohr requested review from edzer, flahn and przell January 5, 2025 16:28
Copy link
Member

@przell przell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matthias,
congrats to the new release.
I have installed the dev version and verified, that

  • compute_result() etc. have the additional argument
  • That RasterCube and VectorCube exist and inherit from DataCube (formally)
  • describe_collection takes strings

To test the new auth method I would need a backend that supports the new method?!

* removed deprecation annotations in RasterCube and VectorCube
* renamed Rd files with suffix ["-deprecated"](https://www.r-bloggers.com/2017/12/r-deprecate-functions-with-roxygen2-3/)
* fixed check note on missing package anchor on \link{}
@m-mohr
Copy link
Member Author

m-mohr commented Jan 8, 2025

@przell Thank you. I think I tested it against the GEE backend with credentials that you could obtain from the Google Cloud API console, but that's pretty advanced. openeo.cloud also supports it, but you'd also need to get specific new credentials from EODC or VITO, I think.

flahn added 3 commits January 12, 2025 23:09
* added testcases for "Datacube" parameter
* fixed naming of parameter with no schema restriction
* fixed is.na issues on $typeCheck
* especially in reducer functions Number objects with ProcessNode as value were validated incorrect
@flahn
Copy link
Member

flahn commented Jan 21, 2025

I have fixed some issues that came up during testing against the GEE backend and with some code examples against VITO backend. For the Client Credentials Workflow I had to setup a local KeyCloak instance on my computer and I configured a client to allow authentication with client credentials. As for now the changes LGTM, so I will merge the PR right away. Next step would be the CRAN release.

@flahn flahn merged commit 5e29445 into master Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants