-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.4.0 #162
Release v1.4.0 #162
Conversation
* Client credentials flow * Fix changelog * Update R/authentication.R * Update man/OIDCAuth.Rd * Code refactoring * Follow logic in Python client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Matthias,
congrats to the new release.
I have installed the dev version and verified, that
compute_result()
etc. have theadditional
argument- That RasterCube and VectorCube exist and inherit from DataCube (formally)
describe_collection
takes strings
To test the new auth method I would need a backend that supports the new method?!
* removed deprecation annotations in RasterCube and VectorCube * renamed Rd files with suffix ["-deprecated"](https://www.r-bloggers.com/2017/12/r-deprecate-functions-with-roxygen2-3/) * fixed check note on missing package anchor on \link{}
@przell Thank you. I think I tested it against the GEE backend with credentials that you could obtain from the Google Cloud API console, but that's pretty advanced. openeo.cloud also supports it, but you'd also need to get specific new credentials from EODC or VITO, I think. |
* added testcases for "Datacube" parameter * fixed naming of parameter with no schema restriction * fixed is.na issues on $typeCheck
* especially in reducer functions Number objects with ProcessNode as value were validated incorrect
I have fixed some issues that came up during testing against the GEE backend and with some code examples against VITO backend. For the Client Credentials Workflow I had to setup a local KeyCloak instance on my computer and I configured a client to allow authentication with client credentials. As for now the changes LGTM, so I will merge the PR right away. Next step would be the CRAN release. |
Release v1.4.0 with the changes listed below.
I did all the changes without deep knowledge of R, so feel free to review and let me know if there's anything that could be improved.
Added
Changed
Fixed
describe_collection
andcollection_viewer
accept string IDs again