Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems when authentication provider is missing #128 #129

Merged
merged 9 commits into from
Aug 18, 2022
Merged

Fix problems when authentication provider is missing #128 #129

merged 9 commits into from
Aug 18, 2022

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Aug 18, 2022

Fixes #128

@m-mohr m-mohr requested a review from flahn August 18, 2022 11:21
@m-mohr m-mohr linked an issue Aug 18, 2022 that may be closed by this pull request
problems logging in on openeo.cloud #128
Closed
@flahn
Copy link
Member

flahn commented Aug 18, 2022

changed it slightly to raise an error with stop(), check explicitly for an empty list and inform the user to contact the back-end provider, because this list should not be empty.

@flahn
Copy link
Member

flahn commented Aug 18, 2022

merged branch develop into this fix, because the target is the develop branch (prior to this the master was merged)

@m-mohr
Copy link
Member Author

m-mohr commented Aug 18, 2022

and inform the user to contact the back-end provider

No, back-ends are free to choose to leave this empty.

@flahn flahn merged commit 2f12153 into develop Aug 18, 2022
@m-mohr m-mohr deleted the fix-128 branch August 18, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flahn flahn flahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problems logging in on openeo.cloud
2 participants
@m-mohr @flahn