changes for Linux

[bgn42]

No description provided.

[github-actions]

Test Results

  6 files  ±0   54 suites  ±0   4s ⏱️ ±0s
160 tests ±0  160 ✅ ±0  0 💤 ±0  0 ❌ ±0 
960 runs  ±0  960 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7a5341a. ± Comparison against base commit ab16c09.

♻️ This comment has been updated with latest results.

[jkrech]

On macOS something goes wrong:

csolution run -g CubeMX CubeMX.csolution.yml
csolution-examples/CubeMX/tmp/CubeMX/MyBoard/Debug/CubeMX.cbuild-gen-idx.yml - info csolution: file is already up-to-date
csolution-examples/CubeMX/tmp/CubeMX/MyBoard/Debug/CubeMX.Debug+MyBoard.cbuild-gen.yml - info csolution: file is already up-to-date
info csolution: generator 'CubeMX' for context 'CubeMX.Debug+MyBoard' reported:
Launching STM32CubeMX with  csolution-examples/CubeMX/STM32CubeMX/MyBoard/STM32CubeMX/STM32CubeMX.ioc
fork/exec csolution-examples/CubeMX/STM32CubeMX/MyBoard/cbridge: no such file or directory
error csolution: executing generator 'CubeMX' for context 'CubeMX.Debug+MyBoard' failed

I think the file to look for is not cbridge butcbridge.cgen.yml

[bgn42]

Hallo Joachim, im Prinzip ist der Kommentar noch richtig. Aber nur für den os.FindProcess-Aufruf. Für Linux und vermutlich auch macOS folgt dann noch ein proc.Signal(syscall.Signal(0)), der sicher feststellt, ob der Prozess noch da ist. Der FindProcess liefert unter Linux nämlich immer ein nil als Error. Viele Grüße, -- Bernd. Von: Joachim Krech ***@***.***> Gesendet: Freitag, 21. Juni 2024 07:05 An: Open-CMSIS-Pack/generator-bridge ***@***.***> Cc: Bernd-Gunter Nitzler ***@***.***>; Author ***@***.***> Betreff: Re: [Open-CMSIS-Pack/generator-bridge] changes for Linux (PR #59) @jkrech commented on this pull request.

________________________________ In internal/stm32CubeMX/stm32CubeMX.go<#59 (comment)>:

@@ -135,6 +151,10 @@ func Process(cbuildYmlPath, outPath, cubeMxPath string, runCubeMx bool, pid int)

for { proc, err := os.FindProcess(pid) // this only works for windows as it is now Is this comment true? How does it work on Linux and macOS then? — Reply to this email directly, view it on GitHub<#59 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWCKMYDA7JQABTM74JPV2SDZIOYA3AVCNFSM6AAAAABJUH3PMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZRG44DOMRZGQ>. You are receiving this because you authored the thread.Message ID: ***@***.***> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[jkrech]

a) MacOS launching with ioc file present, launches STM32CubeMX and cbridge daemon
b) cbridge daemon does not recognise change on .mxproject and no cgen.yml gets generated
c) If no ioc file is present no STM32CubeMX gets launched, there must be something wrong with the invocation. Please add log output.

cbridge tmp/CubeMX/MyBoard/Debug/CubeMX.cbuild-gen-idx.yml  --verbose
Command line: [tmp/CubeMX/MyBoard/Debug/CubeMX.cbuild-gen-idx.yml]
Reading generator.yml file: '/Users/jkrech/cmsis-toolbox/etc/global.generator.yml'
Reading cbuild.yml file: 'tmp/CubeMX/MyBoard/Debug/CubeMX.cbuild-gen-idx.yml'
Writing CubeMX project file /Users/jkrech/project/CubeMX/csolution-examples/CubeMX/STM32CubeMX/MyBoard/project.script
Took 2.402458ms

[bgn42]

a) finally 👍
b) a change on .mxproject cannot be detected because it is deleted an created new. A change will be detected on the .ioc file and, after 4 changes the presence of a new .mxproject will be detected. This somehow works different with CubeMX on macOS. I'll add more debug output to find the difference
c) I'll also add debug output

[codeclimate]

Code Climate has analyzed commit 7a5341a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 1.4% (35% is the threshold).

This pull request will bring the total coverage in the repository to 37.3% (-0.9% change).

View more on Code Climate.

[jkrech]

LGTM