-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device generator #24
Device generator #24
Conversation
Test Results 6 files ± 0 54 suites +6 4s ⏱️ -1s Results for commit f088567. ± Comparison against base commit 909acd8. This pull request removes 3 and adds 33 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, but huge function, hard to read & understand.
Also unsure about the hard codes Cortex-M strings, in mxproject converter I used a more generic approach using the yaml tag "core"
added tests added download info from global.generator.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
In general, not sure if we should have strings for Peripherals to search for rather than just gathering them, but currently no idea how to fetch them from the headerfile :-)
Fixed indeterministic shuffle of contexts in MX_Device.h and added path of MX_Device.h to add-path: in *cgen.yml.