Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86 upgrade requirements #87

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Conversation

roefem
Copy link
Contributor

@roefem roefem commented Nov 24, 2021

No description provided.

@roefem roefem force-pushed the feature/86_upgrade_requirements branch from 1993760 to 2074ca1 Compare November 24, 2021 09:21
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 97.6% when pulling 2074ca1 on feature/86_upgrade_requirements into 702fb0d on develop.

@coveralls
Copy link

coveralls commented Nov 24, 2021

Coverage Status

Coverage increased (+0.9%) to 97.594% when pulling 4dd70aa on feature/86_upgrade_requirements into 702fb0d on develop.

@roefem roefem force-pushed the feature/86_upgrade_requirements branch from 2074ca1 to 0572f8b Compare November 24, 2021 11:10
- 3.7
- 3.8
- 3.9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kben eens bij bram gaan horen. Nieuwe servers zijn weliswaar 3.8, maar omdat er nog steeds bestaande servers zijn die 3.6 draaien zouden we hier best ook op 3.6 blijven testen nog een tijdje, zoals oe-utils.

In de praktijk draaien we 3.7 niet, dus als we travis load willen verkleinen zouden we wel 3.7 kunnen skippen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aie, rdflib vereist python 3,7+. Dan moet die terug downgegrade worden, tenzij python op de bestaande servers omhoog mag.
Fyi, support voor python 3.6 eindigt op 23 Dec, dus misschien wel een goeie reden om dat uit te voeren ineens

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDFlib 6.0.0 is een vrij grote change, die heeft ook ingebakken support voor JSON/LD. Ik zou die voor skosprovider_getty en skosprovider_rdf liever eens apart aangepakt zien worden, kan zijn dat dat nog meer gevolgen zal hebben.

Dus, nu liefst houden op de laatste versie in de 5.x.x reeks en compatibiliteit met Python 3.6 behouden.

@@ -4,8 +4,8 @@
# Testing
pytest==4.6.9 ; python_version < '3.0'
pytest==5.3.5 ; python_version >= '3.0'
pytest-cov==2.8.1
coveralls==1.11.1
pytest-cov==3.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lijn 5 kan weg en 6 kan hoger.

setup.py Outdated
@@ -1,7 +1,7 @@
import os

try:
from setuptools import setup, find_packages
from setuptools import setup

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Als ik wat google denk ik dat distutils een oude manier was die weg kan.

@goessebr goessebr merged commit eeee01f into develop Dec 14, 2021
@goessebr goessebr deleted the feature/86_upgrade_requirements branch December 14, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants