#445 fullscreen fixes #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfe8fd9 to
fd7e14f
Compare
yannickkuypers
requested changes
Aug 21, 2024
| this.options = optOptions || {}; | ||
|
|
||
| const tipLabel = this.options.tipLabel ? this.options.tipLabel : 'Vergroot / verklein het scherm'; | ||
|
|
There was a problem hiding this comment.
welke space precies? "Vergroot/verklein"?
There was a problem hiding this comment.
Ah nee, kvond het wat ambetant dat die 2 const's nen break tussen elkaar hadden staan
yannickkuypers
requested changes
Aug 22, 2024
8ea1b3f to
86a9eb0
Compare
yannickkuypers
requested changes
Aug 22, 2024
| @@ -43,3 +43,9 @@ referentie-laag-map { | |||
| /* adjust the size, position, etc. of the legend for small screens here */ | |||
| } | |||
| } | |||
|
|
|||
| @media all and (display-mode: fullscreen) { | |||
There was a problem hiding this comment.
Is dit nodig? Voor nu zorgt dat nog altijd dat die buttons buiten het scherm vallen
There was a problem hiding this comment.
dit is enkel van toepassing wanneer fullscreen he. Heb de mapnode ietske minder hoog gemaakt.
…lscreen_fixes # Conflicts: # dist/commonjs/zoneerder/components/ol-map.js.map # dist/commonjs/zoneerder/components/referentielaag-autocorrectie.js.map # dist/native-modules/zoneerder/components/ol-map.js.map # dist/native-modules/zoneerder/components/referentielaag-autocorrectie.js.map
yannickkuypers
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.