Improvement/no port flag #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
909c1c0 to
a14a9d5
Compare
Motivation: this flag will allow turning off the port number for dev builds
Motivation: update build script to allow `--no-port` flag when building. New `buildServiceWorker.sh` script injects the build origin into the service worker import.
Motivation: * Switch localhost & texas to avoid confusion * Document the new `no-port` flag
a14a9d5 to
9e16627
Compare
jkasten2
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 2 of 2 files at r2.
Reviewable status: 7 of 11 files reviewed, all discussions resolved (waiting on @jkasten2)
jkasten2
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rgomezp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Adds support for a no-port flag useful when using a reverse proxy like ngrok to serve localhost on the web.
This change is