Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some minor code style issues #37

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fixes some minor code style issues #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/_partials/_head.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,3 @@
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/11.5.0/languages/json.min.js"></script>
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/11.5.0/languages/xml.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@docsearch/js@3"></script>


<%# Implement live_reload_dev_js if needed %>
9 changes: 2 additions & 7 deletions src/_partials/_navbar.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
<nav class="lg:p-6 pt-8 lg:pt-0 lg:w-auto lg:block fixed lg:static top-0 z-10 bg-white dark:bg-zinc-900 transition-all duration-500 max-w-[600px]"
:class="{ 'w-full p-6 pr-0 ': nav_open, 'w-0 p-0 overflow-hidden': !nav_open }">

<%# for covering full width if width<=600px of %>
<%# increase speed of transition by reducing 'duration-[time in ms]' %>
<nav class="lg:p-6 pt-8 lg:pt-0 lg:w-auto lg:block fixed lg:static top-0 z-10 bg-white dark:bg-zinc-900 transition-all duration-500 max-w-[600px]" :class="{ 'w-full p-6 pr-0 ': nav_open, 'w-0 p-0 overflow-hidden': !nav_open }">

<%# for covering full width in all small width screens%>
<%# <nav class="lg:p-6 pt-8 lg:pt-0 lg:w-auto lg:block fixed lg:static top-0 z-10 bg-white dark:bg-zinc-900 transition-all duration-500" :class="{ 'w-full p-6 pr-0 ': nav_open, 'w-0 p-0 overflow-hidden': !nav_open }"> %>

<ul role="list" class='max-h-[100svh] pb-12 lg:pb-0 overflow-y-scroll lg:max-h-fit lg:overflow-auto'>
<li class="relative mt-10 ml-0 mr-5 lg:hidden">
<div id="oba-docs-search-container--mobile"></div>
Expand Down
22 changes: 10 additions & 12 deletions src/_partials/_top_bar.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,32 @@
<div class="hidden lg:block lg:max-w-md lg:flex-auto" id="oba-docs-search-container--desktop">
</div>

<%# showmenu hamburger %>
<div class="flex items-center gap-5 lg:hidden">
<%# hamburger button: show menu %>
<button
@click="nav_open = !nav_open"
type="button"
class="flex h-6 w-6 items-center justify-center rounded-md transition hover:bg-zinc-900/5 dark:hover:bg-white/5":class="{ 'hidden': nav_open }"
class="flex h-6 w-6 items-center justify-center rounded-md transition hover:bg-zinc-900/5 dark:hover:bg-white/5"
:class="{ 'hidden': nav_open }"
aria-label="Toggle navigation">
<svg viewBox="0 0 10 9" fill="none" stroke-linecap="round" aria-hidden="true" class="w-2.5 stroke-zinc-900 dark:stroke-white">
<path d="M.5 1h9M.5 8h9M.5 4.5h9"></path>
</svg>
</button>

<%# close menu %>
<%# close menu %>
<button
@click="nav_open = !nav_open"
type="button"
class="hidden h-6 w-6 items-center justify-center rounded-md transition hover:bg-zinc-900/5 dark:hover:bg-white/5":class="{ '!flex':nav_open }"
class="hidden h-6 w-6 items-center justify-center rounded-md transition hover:bg-zinc-900/5 dark:hover:bg-white/5"
:class="{ '!flex':nav_open }"
aria-label="Toggle navigation">
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" stroke-linecap="round" aria-hidden="true" class="w-2.5 stroke-zinc-900 dark:stroke-white fill-black dark:fill-white"><path d="M24 20.188l-8.315-8.209 8.2-8.282-3.697-3.697-8.212 8.318-8.31-8.203-3.666 3.666 8.321 8.24-8.206 8.313 3.666 3.666 8.237-8.318 8.285 8.203z"/>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" stroke-linecap="round" aria-hidden="true" class="w-2.5 stroke-zinc-900 dark:stroke-white fill-black dark:fill-white">
<path d="M24 20.188l-8.315-8.209 8.2-8.282-3.697-3.697-8.212 8.318-8.31-8.203-3.666 3.666 8.321 8.24-8.206 8.313 3.666 3.666 8.237-8.318 8.285 8.203z"/>
</svg>

</button>
<%= render 'site_logo' %>


<%= render 'site_logo' %>
</div>

<div class="flex items-center gap-5">
Expand All @@ -42,7 +44,3 @@
</nav>
</div>
</div>




Loading