Merge pull request #1774 from SirIntruder/UpdateProjectCompilationOpt…

…ions Fully update CompilationOptions when project files change.
OmniSharp · Apr 30, 2020 · a9ea76f · a9ea76f
2 parents 83d3919 + b90e454
commit a9ea76f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/OmniSharp.MSBuild/ProjectManager.cs b/src/OmniSharp.MSBuild/ProjectManager.cs
@@ -465,7 +465,7 @@ private void UpdateProject(string projectFilePath)
             UpdateProjectProperties(project, projectFileInfo);
 
             _workspace.TryPromoteMiscellaneousDocumentsToProject(project);
-            _workspace.UpdateDiagnosticOptionsForProject(project.Id, projectFileInfo.GetDiagnosticOptions());
+            _workspace.UpdateCompilationOptionsForProject(project.Id, projectFileInfo.CreateCompilationOptions());
         }
 
         private void UpdateAnalyzerReferences(Project project, ProjectFileInfo projectFileInfo)

diff --git a/src/OmniSharp.Roslyn/OmniSharpWorkspace.cs b/src/OmniSharp.Roslyn/OmniSharpWorkspace.cs
@@ -173,6 +173,11 @@ public void UpdateDiagnosticOptionsForProject(ProjectId projectId, ImmutableDict
             OnCompilationOptionsChanged(projectId, project.CompilationOptions.WithSpecificDiagnosticOptions(rules));
         }
 
+        public void UpdateCompilationOptionsForProject(ProjectId projectId, CompilationOptions options)
+        {
+            OnCompilationOptionsChanged(projectId, options);
+        }
+
         private ProjectInfo CreateMiscFilesProject(string language)
         {
             string assemblyName = Guid.NewGuid().ToString("N");