CouchPotato cache scheduler not working

[Drewster727]

Plex Requests.Net Version: 1.8.0

Operating System: Ubuntu 15.10

Mono Version: 4.2.3

Applicable Logs (from /logs/ directory or the Admin page):

Reproduction Steps:

Reset your database so there are no "Requests" anymore. Load up 1.8.0 and setup couchpotato. I have already got Independence Day: Resurgence requested in CP:

Give PR some time to do the caching, check the Scheduled Jobs page and verify it ran the cacher for CP. Then search for Independence Day. You'll see a "Request" button when it should show requested.

This may be happening with Sonarr/SickRage as well, not sure.

[tidusjar]

Thats strange, as I didn't make any changes around those areas...

[tidusjar]

i'll pull the release and investigate

[Drewster727]

I'm seeing that when it tries to connect to CP. Are you seeing that as well?

[tidusjar]

I have not seen that. I'll have to see what's going on when I get home from work.

[Drewster727]

It appears to be successfully connecting to CP and obtaining the data, but it cannot deserialize the json array properly (using RestSharp)

[tidusjar]

Either we have changed a type, or there is a new/changed type that we are not expecting...

[Drewster727]

yea, I'm guessing the CP json changed?

[tidusjar]

Unlikely if an older version works.
I do remember changing one of the types slightly as someone's CP json was structured a bit differently, but i'm pretty sure it still worked

Date: Tue, 21 Jun 2016 07:39:53 -0700
From: notifications@github.com
To: PlexRequests.Net@noreply.github.com
CC: jamierees@outlook.com; assign@noreply.github.com
Subject: Re: [tidusjar/PlexRequests.Net] CouchPotato cache scheduler not working (#334)

yea, I'm guessing the CP json changed?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Drewster727]

I narrowed it down to the "Info" class of our CP object, not sure which property, but commenting all of them but the tmdb_id fixes the issue:

[tidusjar]

Can you send me the Json response you get?

Date: Tue, 21 Jun 2016 07:47:35 -0700
From: notifications@github.com
To: PlexRequests.Net@noreply.github.com
CC: jamierees@outlook.com; assign@noreply.github.com
Subject: Re: [tidusjar/PlexRequests.Net] CouchPotato cache scheduler not working (#334)

I narrowed it down to the "Info" property of our CP object, not sure which property, but commenting all of them but the tmdb_id fixes the issue:

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Drewster727]

looks like the release_date property is the culprit

[Drewster727]

Here's an interesting item I found in the JSON...

sometimes the release_date is: "release_date": []
and sometimes it is: "release_date": {"dvd": 0, "expires": 1468174162, "theater": 0, "bluray": false}

so it can be an array or an object...

[Drewster727]

this may be a solution
http://stackoverflow.com/questions/11513935/gracefully-handling-an-empty-json-object-in-restsharp#answer-27724300

[tidusjar]

Hmmm... The issue would be that we would then do that for everything... I am working on refactoring the Api stuff because it's horrible to work with.

It's either an empty array or an object... well this sounds fun...

[Drewster727]

I'm going to add that as a temp workaround for CP in the meantime. check my latest commit, it works like a charm.

[tidusjar]

Oh it's done in the request and not the response. Yeah looks good!

[Drewster727]

yea, and of course my git screwed up again and committed the entire file(s) instead of just my line changes... so weird.