Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to enable notifications #27

Closed
tidusjar opened this issue Mar 18, 2016 · 10 comments
Closed

Allow users to enable notifications #27

tidusjar opened this issue Mar 18, 2016 · 10 comments
Assignees

Comments

@tidusjar
Copy link
Member

tidusjar commented Mar 18, 2016

Allow a user to receive an notification once the request has been approve and then once the request is available.

@curlz620
Copy link

I love this feature. This would be amazing since a lot of users request something and they never watch it since they forget and don't see it being released.

@tidusjar
Copy link
Member Author

There's quite a few things that need to be done to make this happen. We would need to store the users details e.g. Email address. It is planned. Just don't know when it will be done (sooner rather than later)

@tidusjar tidusjar added this to the Release v1.7.0 milestone Mar 30, 2016
@Drewster727
Copy link
Contributor

can we query the user's plex email address from the plex api? I'm going to assume no... but figured I'd ask.

@tidusjar
Copy link
Member Author

That's a good point. I think it does contain that.

@Drewster727
Copy link
Contributor

if that's the case, we can enable this option in the email settings start and do it pretty easily.

@tidusjar
Copy link
Member Author

We still need to allow the user to enable it. They may not want the notifications.

@Drewster727
Copy link
Contributor

o right, of course. 👍

@EddiYo
Copy link

EddiYo commented Apr 1, 2016

How about making that a checkbox when they do add the requests @tidusjar ?

Maybe even add the possibility of checking and unchecking notifications for requests made for other users as well? Probably not as easy as it sounds to implement tho..

@tidusjar
Copy link
Member Author

tidusjar commented Apr 1, 2016

@EddiYo I think that will complicate things, All we need is a page where the user can enable notifications, and they can turn it off and on :) We don't need their email as we can get it from the Plex Api. But if they want pushbullet or pushover notifications then we will need their api keys.

@Drewster727
Copy link
Contributor

I say we keep it super simple to start with, and just show a check box on the main search page above the tabs. this assumes we have emailing setup, so we'd need to check if that's enabled before showing this option for the user.

tidusjar pushed a commit that referenced this issue Apr 25, 2016
…yling). Also fixed a bug where if the user could only see their own requests, if they search for something that has been requested, it will show as requested.
tidusjar pushed a commit that referenced this issue Apr 25, 2016
tidusjar pushed a commit that referenced this issue Apr 25, 2016
tidusjar pushed a commit that referenced this issue Apr 25, 2016
tidusjar pushed a commit that referenced this issue Apr 25, 2016
tidusjar pushed a commit that referenced this issue May 20, 2016
tidusjar pushed a commit that referenced this issue May 20, 2016
@tidusjar tidusjar self-assigned this May 20, 2016
tidusjar pushed a commit that referenced this issue May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants