Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a Sonarr file path on approval #170

Closed
R-Jimenez opened this issue Apr 19, 2016 · 18 comments
Closed

Specify a Sonarr file path on approval #170

R-Jimenez opened this issue Apr 19, 2016 · 18 comments

Comments

@R-Jimenez
Copy link

Obligatory 'Holy crap this makes everything much easier thanks a ton for working on this project xoxoxo'

Ehem. Anyways, as the title might suggest, I would love it if the Sonarr integration would allow me to specify the file path on a per-series basis. So that when I click approve on the requests panel, instead of using the default path found in the settings, I could instead use a certain path for certain shows, as needed.

@tidusjar
Copy link
Member

Just trying to think how this would fit into the UI and flow, so maybe another dropdown option on the Approval button? What do you think?

@evilspectre
Copy link

Not OP, but was coming here to request same thing, another drop down would work, you could also put that info into approved/available/requested by list like https://i.imgur.com/81MQkWq.png

Also, I was going to make a similar request for Movies/CouchPotato and adding another drop down for Categories, do you want that a separate issue?

@tidusjar
Copy link
Member

@evilspectre Yeah if we added another dropdown we would make sure we display it on the requests page.

Regarding the categories yes can you please raise that separately :)

@R-Jimenez
Copy link
Author

Either solution would be great! Having it tied to the request like @evilspectre suggested may be my preferred method (similar to Sonarr's object design), but something like Approve ([category name]) would work just fine, and users can just set up file categories in their config like everything else.

@tidusjar
Copy link
Member

Well I was thinking, for TV under the approve dropdown there would be a new option Approve with path or something like that. That will then give you some sort of text box to specify a file path for that single approval ? Opinions?

@R-Jimenez
Copy link
Author

Fine by me. Simply having the capability is more than enough for my needs.

@tidusjar
Copy link
Member

I'm just wondering on the most user friendly way to do things (I don't have a need for this functionality).

What's the usual usecase? You would have series 1 = C:\Series\Series 1 and series 2 = D:\Series\Series 2?

@R-Jimenez
Copy link
Author

I have three distributed media folders across three drives, but yeah, you've got the gist of the usecase. Live-action dramas go on one drive, anime on another, etc.

@evilspectre
Copy link

Same, have a /Media/TV /Media/Cartoons and a /Media/Anime folders

@onedr0p
Copy link
Contributor

onedr0p commented Sep 10, 2016

The best way to implement this IMO would be to expand on the dropdown under the approve button.

First separate the out the headers (Quality Profile, Path & others if we can add later) and then add a botton 'Done' to the dropdown that will submit those settings to the Sonarr API

Button: [+ Approve] onClick show dropdown =>
  Label: Quality Profile
    Radio button: [✓] Any
    Radio button: [  ] SD
    Radio button: [  ] HD
  Label: Path
    Radio button: [✓] /path/to/Airing TV Shows
    Radio button: [  ] /path/to/Archived TV Shows
  Button: [Done]

For the Path, we would need to send a request to Sonarrs API to gather all existing paths which shouldn't be hard.

If that all makes sense we could use the framework for the UI to implement specifing the Categories in CP too. Overall this shouldn't take much time to implement, if there is a frontend plugin for jQuery that would help. I would take a stab at this if I had more time.

Let me know your thoughts.

Edit: A simpler... less elegant solution would be when you press Approve have a modal pop up in the center of the screen with the options.

@tidusjar
Copy link
Member

@onedr0p I like it!

But I think we should keep the default in the settings, saves having to select the same options every time.

@onedr0p
Copy link
Contributor

onedr0p commented Sep 12, 2016

@tidusjar I took sometime over the weekend and started implementing this. But, my lack of knowledge in c# is proving it to be harder than I thought. I come from a python/php background. Could I push a new branch and see if you can help out with it?

What is implemented:

  • Grabbing the root folders via sonarr api
  • In sonarr admin settings a button to refresh root folders and they show in the dropdown (like quality profiles)
  • The selectbox gets populated with the root folders, but doesn't save in cache when you click save for some reason?? (it's not populated on page refesh)

@tidusjar
Copy link
Member

Sure, just link me and i'll assist!

@onedr0p
Copy link
Contributor

onedr0p commented Sep 12, 2016

Awesome! I am at work now, but when I'm out (~8 hours) I'll push over a new branch so you can take a look.

@tidusjar
Copy link
Member

You could just fork the code and just commit it to the dev branch, easier to merge then.

@onedr0p
Copy link
Contributor

onedr0p commented Sep 12, 2016

Ok, I'll do that. I just didn't know if you wanted it on the Dev branch because it is incomplete.

@Magikarplvl4
Copy link
Contributor

Case in progress in a pull request #535

@Magikarplvl4 Magikarplvl4 modified the milestones: Release v2.0, V2.1 release Jan 4, 2017
@Magikarplvl4 Magikarplvl4 modified the milestones: V2.X release pool , 2.1 Jan 12, 2017
tidusjar pushed a commit that referenced this issue Jan 23, 2017
@tidusjar tidusjar removed the planned label Jan 23, 2017
@onedr0p
Copy link
Contributor

onedr0p commented Jan 23, 2017

Fuck yes, thanks dude!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants