Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete TV Shows from Suggestions fail to add #1133

Closed
simonk83 opened this issue Feb 17, 2017 · 1 comment
Closed

Incomplete TV Shows from Suggestions fail to add #1133

simonk83 opened this issue Feb 17, 2017 · 1 comment

Comments

@simonk83
Copy link

simonk83 commented Feb 17, 2017

Ombi Version:

V 2.1.1412

Update Branch:

Early Access Preview

Operating System:

Mono (via Docker on a Synology)

Mono Version (only if your not on windows)

4.6.2 (Stable 4.6.2.16/ac9e222 Tue Jan 3 11:48:26 UTC 2017)

Applicable Logs (from /logs/ directory or the Admin page):


System.Runtime.Serialization.SerializationException: Invalid JSON string at RestSharp.SimpleJson.DeserializeObject (System.String json) [0x0000c] in :0 at RestSharp.Deserializers.JsonDeserializer.FindRoot (System.String content) [0x00000] in :0 at RestSharp.Deserializers.JsonDeserializer.Deserialize[T] (RestSharp.IRestResponse response) [0x00007] in :0 at RestSharp.RestClient.Deserialize[T] (RestSharp.IRestRequest request, RestSharp.IRestResponse raw) [0x0005c] in :0	

Problem Description:

If you choose one of the suggested lists (Most Anticipated in this case) and try and add a show that hasn't fully scraped (missing poster), such as Marvel's Iron Fist or Star Trek: Discovery, the add fails with the above error in the logs, but no visible sign of error (other than infinite spinning).

Reproduction Steps:

See description above. I guess either don't show the items that can't be scraped (the IMDB link works so I assume you're not grabbing details from there, unless it's OMDB which is having some issues at the moment), handle the error gracefully with a message, or add an alternative for scraping the details (easier said than done I'm sure).

@Ombi-robot
Copy link

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Before posting make sure you also read our FAQ and known issues.
Make the title describe your issue. Having "not working" or "I get this bug" for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Cheers!
Ombi Support Team

tidusjar pushed a commit that referenced this issue Feb 17, 2017
Do not show shows that we do not ahve any information for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants