* userManagementController.js: fixed #881

* UserManagementModule.cs:
Ombi-app · Jan 2, 2017 · f074f28 · f074f28
1 parent 34e00e1
commit f074f28
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 17 deletions.
diff --git a/Ombi.UI/Content/app/userManagement/userManagementController.js b/Ombi.UI/Content/app/userManagement/userManagementController.js
@@ -74,13 +74,16 @@
                 }
             }
 
+            if(Array.isArray($scope.users)){
+
             var existingUsername = $scope.users.some(function (u) {
                 return u.username === $scope.user.username;
             });
 
             if (existingUsername) {
                 return generateNotify("A user with the username " + $scope.user.username + " already exists!", 'danger');
             }
+             }
 
             userManagementService.addUser($scope.user, $scope.selectedPermissions, $scope.selectedFeatures)
                 .then(function (data) {
@@ -92,6 +95,8 @@
                         clearCheckboxes();
                     };
                 });
+
+
         };
 
         // Watch the checkboxes for updates (Creating a user)

diff --git a/Ombi.UI/Modules/UserManagementModule.cs b/Ombi.UI/Modules/UserManagementModule.cs
@@ -86,23 +86,20 @@ private async Task<Response> LoadUsers()
             {
                 //Get Plex Users
                 var plexUsers = PlexApi.GetUsers(plexSettings.PlexAuthToken);
-
-                foreach (var u in plexUsers.User)
-                {
-                    var dbUser = plexDbUsers.FirstOrDefault(x => x.PlexUserId == u.Id);
-                    var userDb = userLogins.FirstOrDefault(x => x.UserId == u.Id);
-
-                    // We don't have the user in the database yet
-                    if (dbUser == null)
-                    {
-                        model.Add(MapPlexUser(u, null, userDb?.LastLoggedIn ?? DateTime.MinValue));
-                    }
-                    else
-                    {
-                        // The Plex User is in the database
-                        model.Add(MapPlexUser(u, dbUser, userDb?.LastLoggedIn ?? DateTime.MinValue));
-                    }
-                }
+				if (plexUsers != null && plexUsers.User != null) {
+					foreach (var u in plexUsers.User) {
+						var dbUser = plexDbUsers.FirstOrDefault (x => x.PlexUserId == u.Id);
+						var userDb = userLogins.FirstOrDefault (x => x.UserId == u.Id);
+
+						// We don't have the user in the database yet
+						if (dbUser == null) {
+							model.Add (MapPlexUser (u, null, userDb?.LastLoggedIn ?? DateTime.MinValue));
+						} else {
+							// The Plex User is in the database
+							model.Add (MapPlexUser (u, dbUser, userDb?.LastLoggedIn ?? DateTime.MinValue));
+						}
+					}
+				}
 
                 // Also get the server admin
                 var account = PlexApi.GetAccount(plexSettings.PlexAuthToken);