Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #3 - makes it work with wide unicode characters #4

Merged
merged 2 commits into from
May 7, 2020
Merged

fixes #3 - makes it work with wide unicode characters #4

merged 2 commits into from
May 7, 2020

Conversation

fogine
Copy link
Contributor

@fogine fogine commented Apr 3, 2020 •
edited
Loading

  • do not use g_strescape as it breaks multi-byte unicode characters:

Escapes all characters in the range 0x01-0x1F (everything below SPACE) and in the range 0x7F-0xFF (all non-ASCII chars) are replaced with a '' followed by their octal representation.

  • escapes only necessary json control characters
  • reads multi-byte utf-8 characters correctly from child process stdout

@OmarCastro OmarCastro merged commit 51b269b into OmarCastro:master May 7, 2020
OmarCastro added a commit that referenced this pull request May 9, 2020
@OmarCastro
src: improvements on #4: code review & add exmaple
42b5cbd 
- Code review pull request

- Add icon character on show_lines example to show that
even icon multibyte characters works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fogine @OmarCastro