Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval file in clojure nREPL on Windows isn't working. #505

Closed
UnderCooled opened this issue Jun 14, 2023 · 3 comments
Closed

Eval file in clojure nREPL on Windows isn't working. #505

UnderCooled opened this issue Jun 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@UnderCooled
Copy link

extract.file-path returns a path like this on Windows: D:\foo\bar.clj, then it's double-quoted in eval-file, "D:\foo\bar.clj", those backslashes become escape like \f, \b.

" \"" opts.file-path "\")"))

opts.file-path should be escaped on Windows platform: (nvim.fn.escape opts.file-path "\\") or (opts.file-path:gsub "\\" "\\\\").

@Olical
Copy link
Owner

Olical commented Jun 24, 2023

Ah no! Sorry, I'll get this fixed as soon as I can. Thanks you for reporting and sorry for the error, Windows paths always catch me out, we did a huge pass a year or so ago to escape everything and use the right slashes everywhere, I guess something slipped the net or was added later.

@Olical Olical added the bug Something isn't working label Jun 24, 2023
@Olical
Copy link
Owner

Olical commented Jul 5, 2023

Pushed a fix for this to develop.

@UnderCooled
Copy link
Author

It works great!

@Olical Olical closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants