Fix: changed Spond.get_events() subgroupId Param to subGroupId
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliot-100
approved these changes
Feb 11, 2025
|
@Olen would you be OK to release a new version with this bugfix please? |
|
Sure. Give me some time to get home and do stuff |
|
of course, no pressure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After failing to restrict the event search to a specific subgroup, I realized that Spond's API uses subGroupId with a capital 'G' instead of subgroupId.
After reviewing this issue, I believe subGroupId is the correct parameter. However, due to certain circumstances, I'm currently unable to test whether my commit resolves the issue.