Issue 33: Allow validation to be skipped when an item has a semantically equal value

[OldSneerJaw]

Description

Introduces the skipValidationWhenValueUnchanged constraint for all validation types. When enabled, validation is not performed on the property or element when it semantically equals the value from the previous revision (e.g. a datetime of "2018-06-13T18:01-07:00" is semantically equal to "2018-06-13T21:01-04:00"). The result is that, even if the property or element no longer satisfies the item constraint(s), its value will be allowed if it has not changed.

NOTE: This pull request is part 1 of 2. The next pull request will add a skipValidationWhenValueUnchangedStrict constraint that requires strict (rather than semantic) equality.

Testing

1. Generate a validation function from skip-validation-when-value-unchanged-doc-definitions.js:

./make-validation-function -j test/resources/skip-validation-when-value-unchanged-doc-definitions.js build/test-validation-function.txt

2. Copy and paste the generated validation function into a CouchDB design document.
3. Create a valid dynamicSkipValidationWhenValueUnchangedDoc document (should be accepted with 201 Created):

PUT /test/skip-validation-test-1 HTTP/1.1
Host: localhost:5984
Content-Type: application/json
Authorization: Basic ********

{
	"type": "dynamicSkipValidationWhenValueUnchangedDoc",
	"allowValidationSkip": true,
	"uuidProp": "c3bb1830-12e5-4bb9-8a46-df7098c30fe0"
}

4. Attempt to replace the document with one that fails validation because its uuidProp value is invalid and it is not equal to the old value (should be rejected with 403 Forbidden):

PUT /test/skip-validation-test-1?rev=1-5bd12c723a15dca84ea624a1b01b91bd HTTP/1.1
Host: localhost:5984
Content-Type: application/json
Authorization: Basic ********

{
	"type": "dynamicSkipValidationWhenValueUnchangedDoc",
	"allowValidationSkip": true,
	"minimumUuidValue": "d0000000-0000-0000-0000-000000000000",
	"uuidProp": "720f142a-398e-4c6c-986f-0b2df8784722"
}

5. Replace the document with one that would fail validation if not for the fact that its uuidProp value is semantically equal to the old value (should be accepted with 201 Created):

PUT /test/skip-validation-test-1?rev=1-5bd12c723a15dca84ea624a1b01b91bd HTTP/1.1
Host: localhost:5984
Content-Type: application/json
Authorization: ********

{
	"type": "dynamicSkipValidationWhenValueUnchangedDoc",
	"allowValidationSkip": true,
	"minimumUuidValue": "d0000000-0000-0000-0000-000000000000",
	"uuidProp": "C3BB1830-12E5-4BB9-8A46-DF7098C30FE0"
}

Related Issue

• GitHub issue link: Option to ignore item validation errors when value is unchanged #33

[dkichler]

👍