Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CodeQL from pipeline level and add it in job level #2698

Merged
merged 5 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ extends:
- repository: AppHostingSdkV4
- repository: AndroidAppHostingSdk
- repository: IOSAppHostingSdk
codeql:
maglims marked this conversation as resolved.
Show resolved Hide resolved
compiled:
enabled: false
justificationForDisabling: 'CodeQL has some known issues with arm64 macos. Disabling auto-injection and using manual task instead'
customBuildTags:
- ES365AIMigrationTooling
stages:
Expand Down
7 changes: 7 additions & 0 deletions tools/yaml-templates/android-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ steps:
script: 'nohup pnpm start-test-app &'
workingDirectory: '$(ClientSdkProjectDirectory)'

- task: CodeQL3000Init@0
maglims marked this conversation as resolved.
Show resolved Hide resolved
inputs:
Enabled: true

- task: Bash@3
displayName: 'Install Emulator'
# This task is flaky, but when it works it almost always completes in under 5 minutes.
Expand Down Expand Up @@ -88,6 +92,9 @@ steps:
script: 'chmod u+x ./gradlew && chmod u+x e2eTest.sh && ./e2eTest.sh ${{ parameters.shardNum }} ${{ parameters.shardIndex }}'
workingDirectory: '$(Agent.BuildDirectory)/androidHost/apps/orangeandroid'

- task: CodeQL3000Finalize@0
condition: always()

- task: Bash@3
displayName: 'Pull Test Artifacts'
inputs:
Expand Down
9 changes: 8 additions & 1 deletion tools/yaml-templates/build-app-host.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ steps:
workingDirectory: '$(AppHostingSdkProjectDirectory)'
condition: eq(variables.CYPRESS_CACHE_RESTORED, 'false')

- task: CodeQL3000Init@0
maglims marked this conversation as resolved.
Show resolved Hide resolved
inputs:
Enabled: true

- script: |
pnpm build
displayName: 'Build app hosting sdk'
Expand All @@ -87,11 +91,14 @@ steps:
pnpm build-force-blazor
displayName: 'Build client sdk'
workingDirectory: '$(ClientSdkProjectDirectory)'

- task: CmdLine@2
displayName: 'Configure host machine'
inputs:
script: |
sudo chmod -R 755 ./
pnpm run setup
workingDirectory: '$(AppHostingSdkProjectDirectory)'

- task: CodeQL3000Finalize@0
condition: always()
9 changes: 8 additions & 1 deletion tools/yaml-templates/ios-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ steps:
script: 'nohup pnpm start-test-app --server-options-cert $(localhostSSLCertificate.secureFilePath) --server-options-key $(localhostSSLKey.secureFilePath) &'
workingDirectory: '$(ClientSdkProjectDirectory)'

- task: CodeQL3000Init@0
inputs:
Enabled: true

# Ideally, iOS Host SDK will be built as a dependency before running E2E Test, but there is no harm to build it again for a minute.
# In practice, building iOS Host SDK before E2E test reduces flaky failure rate comparing to run E2E test directly.
- task: Xcode@5
Expand All @@ -100,7 +104,10 @@ steps:
xcWorkspacePath: '/Users/runner/work/1/iOSHost/$(IOSSdkWorkspace).xcworkspace'
xcodeVersion: 'default'
xcodeBuildArguments: 'CODE_SIGNING_ALLOWED=NO clean build -derivedDataPath "$(agent.buildDirectory)/iOS/DerivedData"'


- task: CodeQL3000Finalize@0
condition: always()

- task: Bash@3
displayName: 'Disable Slow Animation'
inputs:
Expand Down
Loading