Deekshanyab/botconfigschema #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated readme title and added description to metadata (so that this repo can be onboarded to the MSSamples gallery)
* Set manifestVersion to 'devPreview' * Add 'supportsCalling' and 'supportsVideo' to bots * adding show Loading indicator to dev preview (#83) * addign show Loading indcator to dev preview * addressing comments * schema v1.6 * updated spaces * 1.6 -> devPreview Co-authored-by: Matt Stankiewicz <mastank@microsoft.com> Co-authored-by: Sachin Gupta <hapysachin91@gmail.com>
Co-authored-by: Stephen Houston <sthousto@microsoft.com>
Co-authored-by: Charles Chao <v-jicha1@microsoft.com>
* manifest schema 1.10 * update README Co-authored-by: Charles Chao <v-jicha1@microsoft.com>
Co-authored-by: Allen <asnow@allensnow.com>
* manifest schema 1.10 * added manifest 1.11 Co-authored-by: Charles Chao <v-jicha1@microsoft.com>
* manifest schema 1.10 * added manifest 1.11 * manifest 1.11 Co-authored-by: Charles Chao <v-jicha1@microsoft.com>
* manifest schema 1.10 * manifest 1.12 Co-authored-by: Charles Chao <v-jicha1@microsoft.com>
* manifest schema 1.10 * updated manifest 1.12 * updated manifest 1.12 Co-authored-by: Charles Chao <v-jicha1@microsoft.com>
* manifest schema 1.10 * added manifest 1.14 * removed scopesConstraints * updated description of supportedChannelTypes * updated description of supportedChannelTypes Co-authored-by: Charles Chao <v-jicha1@microsoft.com>
* added manifest 1.16 * update
charlesji-msft-teams
previously approved these changes
Sep 8, 2023
charlesji-msft-teams
approved these changes
Sep 11, 2023
| "description": "A boolean value that indicates if it should fetch bot config task module dynamically", | ||
| "default": false | ||
| }, | ||
| "taskInfo": { |
There was a problem hiding this comment.
The same definition of "taskInfo" was repeated 3 times, could we make it a common component that can be referenced.
AkJo
approved these changes
Sep 22, 2023
AkJo
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bot configuration changes to dev preview schema