passing add-in url via dist gulp task using --url parameter #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add gulp-replace to devdependecy tests
|
Hi @jthake , Amr |
|
@beth-panx I see that this repo got more love recently which is great , I have this PR sitting still for around 4 months now . Amr |
|
Hi @ministainer I am working on reviewing pull requests as well as closing issues.. We are currently on the stage of prioritizing some of the works that needs to be done. This is def on my task list :) |
beth-panx
reviewed
Oct 5, 2016
| @@ -1,6 +1,8 @@ | |||
| 'use script'; | |||
|
|
|||
| var gulp = require('gulp'); | |||
| var replace=require('gulp-replace'); | |||
| var argv = require('yargs').argv; | |||
There was a problem hiding this comment.
Should this package be added to package.json?
There was a problem hiding this comment.
@beth-panx it should let me add it and update tests as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passing add-in url via dist gulp task using --url parameter
examples :
gulp dist --url https://myserver.local/gulp dist --url https://myaddin.azurewebsites.net/