Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows Support #48

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Add Windows Support #48

merged 4 commits into from
Jul 2, 2024

Conversation

joewnga
Copy link
Contributor

@joewnga joewnga commented Jun 24, 2024

Added Windows Support

Please provide a summary of the changes and any backward incompatibilities.

Checklist

  • I have documented these changes where necessary.
  • I have read the DCO and ensured that these changes comply.
  • I assign this work under its open source licensing.

rauljordan
rauljordan approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@rauljordan
Copy link
Contributor

Looks like you need to run cargo fmt @joewnga

@joewnga
Copy link
Contributor Author

joewnga commented Jun 24, 2024

@rauljordan, this has been done.

@rauljordan rauljordan merged commit 695f074 into OffchainLabs:main Jul 2, 2024
2 of 7 checks passed
@joewnga joewnga deleted the add-windows-support branch July 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cargo-Stylus failed to build on Windows
2 participants
@joewnga @rauljordan