Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: step template issues #828

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: step template issues #828

merged 2 commits into from
Nov 28, 2024

Conversation

domenicsim1
Copy link
Contributor

@domenicsim1 domenicsim1 commented Nov 28, 2024

closes #827
closes #826
closes #829

@domenicsim1 domenicsim1 changed the title fix: panic on resource tenant project error handling fix: step template issues Nov 28, 2024
@@ -163,6 +163,7 @@ func GetStepTemplateParameterResourceSchema() rs.ListNestedAttribute {
"label": rs.StringAttribute{
Description: "The label shown beside the parameter when presented in the deployment process. Example: `Server name`.",
Optional: true,
Computed: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the user can set it?

Copy link
Contributor Author

@domenicsim1 domenicsim1 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies that the user can set it but so can the api/provider if they don't.

@domenicsim1 domenicsim1 merged commit e709e02 into main Nov 28, 2024
22 checks passed
@domenicsim1 domenicsim1 deleted the fix/step_template_issues branch November 28, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants