Fix tenant tags producing inconsistent result after apply after updating to plugin framework #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to plugin framework
42dd214 to
bfcfaf9
Compare
aab4453 to
2643e57
Compare
domenicsim1
approved these changes
Nov 18, 2024
| @@ -108,7 +108,7 @@ func (t TenantSchema) GetDatasourceSchema() datasourceSchema.Schema { | |||
| "id": GetIdDatasourceSchema(true), | |||
| "name": GetReadonlyNameDatasourceSchema(), | |||
| "space_id": GetSpaceIdDatasourceSchema("tenant", true), | |||
| "tenant_tags": datasourceSchema.ListAttribute{ | |||
| "tenant_tags": datasourceSchema.SetAttribute{ | |||
There was a problem hiding this comment.
Do we need a migration for this or will existing configurations with lists already in state just handle swapping to set fine?
There was a problem hiding this comment.
Yeah, it does. Having said that, the existing configuration doesn't work at all, anyway. If they did use the workaround to sort the tags alphabetically on the resource, it should just work. The state files don't look any different to what it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Our terraform provider creates invalid plans for a lot of the resources because we are using lists that are intended to be ordered. This is fine with other resources, because it is "tolerated because of the legacy plugin SDK".
There has been a recent update on this resource to use the newer terraform framework - and we no longer have this exemption. This PR addresses this.
Fixes #802
[sc-97302]