Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retention policy plan validation #752

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Retention policy plan validation #752

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
115b16f
bugfix/retention policy plan validation
HuyPhanNguyen Aug 19, 2024
486e3c6
Update document
HuyPhanNguyen Aug 19, 2024
fb531ce
Update example
HuyPhanNguyen Aug 19, 2024
13bf5c7
Update octopusdeploy_framework/schemas/lifecycle.go
HuyPhanNguyen Aug 19, 2024
e6c32d1
fix build issue
HuyPhanNguyen Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix build issue
  • Loading branch information
@HuyPhanNguyen
HuyPhanNguyen committed Aug 19, 2024
commit e6c32d1bb300040a5272012939d40a97523cb979
5 changes: 3 additions & 2 deletions octopusdeploy_framework/schemas/lifecycle.go
View file
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@ import (
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
"github.com/hashicorp/terraform-plugin-framework/tfsdk"
"github.com/hashicorp/terraform-plugin-framework/types"
"strings"
)

func GetResourceLifecycleSchema() resourceSchema.Schema {
@@ -202,11 +203,11 @@ func (v retentionPolicyValidator) ValidateObject(ctx context.Context, req valida

if !retentionPolicy.Unit.IsNull() {
unit := retentionPolicy.Unit.ValueString()
if !strings.EqualFold(unit, "Days") && !strings.EqualFold(unit,"Items") {
if !strings.EqualFold(unit, "Days") && !strings.EqualFold(unit, "Items") {
resp.Diagnostics.AddAttributeError(
req.Path.AtName("unit"),
"Invalid retention policy unit",
"Unit must be either 'Days' or 'Items'",
"Unit must be either 'Days' or 'Items' (case insensitive)",
)
}
}
Loading