Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OctoPrint-MfaTotp plugin #1346

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Add OctoPrint-MfaTotp plugin #1346

merged 4 commits into from
Jan 28, 2025

Conversation

foosel
Copy link
Member

@foosel foosel commented Jan 27, 2025

As part of preparing the first RC for 1.11.0, the MFA-TOTP plugin now also needs to be added to the repo, as a reference implementation for multi factor plugins, and also for additional security.

It shows that it's been a while that I added a plugin myself, right? ^^
Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you wanted to wait to merge this until the RC release, but everything looks good from a review perspective.

@foosel
Copy link
Member Author

foosel commented Jan 27, 2025

Plan to push out the RC tomorrow (originally wanted to do it today, but some issues with this one were blocking me), will push this out then ^^ Thanks!

@foosel foosel merged commit 3a58e9e into gh-pages Jan 28, 2025
4 checks passed
@foosel foosel deleted the add-mfa-totp branch January 28, 2025 12:40
@QuinnDamerell
Copy link
Contributor

This is a lovely upgrade! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants