Particle updating #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored into better library structured as discussed. See the README.md for a better description of the library. Also added method to derive PAR from integrating chlorophyll (I also think there may have been a missing factor of 1/r_pig in the original version).
…ource/sink particles (kelp example may not work yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly happy that I've now got it working so you can make particles which track fields, have properties which can depend on those fields, and then act as a source or sink to the tracer fields.
The testing suite is hopefully convincing that the source/sink function correctly conserves the tracer concentration now, and that the PAR is being correctly calculated (I have discussed with @syou83syou83 that we will change to a different attenuation implementation because the factor of r_pig in the paper LOBSTER is possibly not meant to be there).