Added N conserving option for sinking tracers, timestep utility, and modified examples #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagoosw
referenced
this pull request
Aug 20, 2022
|
Also realized where I was iterating over kappa before it was incorrect and only going 1 to 365s not the whole year (hence the change in c since I've essentially trial and error worked out that 2.6min time step is about as low as it can go with the sediment model and the grid as configured in the example). |
|
@syou83syou83 I've changed the examples a bit and cleaned up the directory, hope thats okay with you? I'll add some plots to the readme at some point then merge. |
|
Sorry just got off a plane but when I was flying I realised the timestep difference between some of the models is because of the diffusivity. When I'm using ~2.6mim the max diffusivity is 2e-2 so I would expect about 30 seconds for the normal 8e-2 FYI @syou83syou83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time step utility is (unsupprisingly) a lot slower than Oceananigans' ones for nonfunctional diffusivity so probably shouldn't use this during the simulation like they do for TimestepWizard, alternatively could by much less regularly. May do that as a test that this is actually the limiting factor.