Modified particles to conserve tracers if sinking below zero, and fixed light #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now instead of allowing tracers to go below zero the model requires fallback properties of the particles to be defined where the deficite is taken from. For example, in the SLatissima model this is N (gN/dm^2) so we also require a "scale factor" which in this case is the A property and the unit conversion from mmolN to gN. Also updated tests.
|
Fixed the conservation issue now @johnryantaylor It is slightly more complicated than I was expecting because N is per unit area, so to keep it general I have made it so that for each sink field you define a fallback property (of the particles) to take the defecate from, in this case N, as well as a scale factor. The scale factor can be a number, e.g. if the kelp model just tracked mass of nitrogen, or a number and another particle property to divide by, in this case A. |
|
Added a test for the /A case and looks good |
|
Turns out I had broken the light function but repaired now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now instead of allowing tracers to go below zero the model requires
fallback properties of the particles to be defined where the deficite
is taken from. For example, in the SLatissima model this is N (gN/dm^2)
so we also require a "scale factor" which in this case is the A property
and the unit conversion from mmolN to gN.
Also updated tests.