Adds MultiBandPhotosyntheticallyActiveRadiation
#205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed gas exchange docstring
…r things happen instead
Updated name of Centre for Climate Repair in README
swapped order of paragraphs in description
b855e46 to
7279f6f
Compare
|
I'm going to merge this with main when the oceananigans patch is out, and then you can pull main into the PISCES branch because that will probably be less confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
MultiBandPhotosyntheticallyActiveRadiationwith default parameters replicating the "Morel" model used in other implementations of PISCES.It required a small PR into Oceananigans to make it work (CliMA/Oceananigans.jl#3683) which is now merged and just waiting for a release, so this PR currently changes to use Oceananigans main branch instead for now (but this should not be merged into main).