-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert projection works in 8.9.1 but not in 12.2.0 #446
Comments
I hotfixed a very similar issue today. Which followed from the projection check I added monday to determine if the projection given as: provider:code ie. EPGS:4326 is actually a projection and not ie. a datum. Testing as we speak to confirm the issue is resolved or requires more investigation. To be continued.. |
Can confirm that the issue is still present. To be further investigated. |
Reopened issue, performance regression needs further investigation. |
From the gdal docs on OGRCreateCoordinateTransformation, which we use to create the transformation block, it states several available options. The OGR_CT_OP_SELECTION appears to be the culprit and default set to PROJ, which means that for every point the best reprojection pipeline is determined, which may involve a Taylor expansion for every area around each point. Changing this option to BEST_ACCURACY makes the code run in a split second again. |
Next to the above finding, we also rewritten the coordinate transformation logic to be more clear and efficient, passing in batches of points instead of points separately. |
… issue #446. Made sure CPLSetConfigOption("OGR_CT_OP_SELECTION", "BEST_ACCURACY"); is set.
Latest version of GeoDMS will be similar in speed for coordinate transformations compared to version 8.9.1. Furthermore we will add multiple point coordinate transformations to our unit tests to test performance regression in the future. |
Make regression test for coordinate transformation of multiple geometries. @mtbeek32 |
regression test added to full test. |
conversion from a geometry in EPSG 31300 (belgium) to EPSG 28992 (Netherlands) does work in geodms 8.9.1 but not in 12.2.0.
In 12.2.0 nothing appears in mapview, tableview is empty with only id's.
PD (incl SD) https://pbl.sliksvn.com/ruimtescanner/PBL/ProjDir/branches/Cursus_MartijnSpoon rev10130 (revision numbers matters!)
item: /Vlaanderen/Gemeente_pol/Geometry_rd
8.9.1


12.2.0
The text was updated successfully, but these errors were encountered: