Allows to throw own exception messages in admin login #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sieg
added a commit
that referenced
this pull request
Nov 8, 2021
Related #882 Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Sieg
added a commit
that referenced
this pull request
Nov 8, 2021
Related #882 Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Sieg
added a commit
that referenced
this pull request
Nov 8, 2021
As exception message is not hardcoded and not overwritten by the controller anymore, its more precise. Related #882 Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Sieg
added a commit
that referenced
this pull request
Nov 9, 2021
Related #882 Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Sieg
added a commit
that referenced
this pull request
Nov 9, 2021
As exception message is not hardcoded and not overwritten by the controller anymore, its more precise. Related #882 Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Sieg
added a commit
that referenced
this pull request
Nov 10, 2021
Related #882 Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Sieg
added a commit
that referenced
this pull request
Nov 10, 2021
Related #882 Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
|
Hello @moritzdemmer. Thanks for the improvement. Merged to b-6.4.x and up to master with several changes: 2ce41dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There is no possibility to throw your own error messages in the admin login area as the message is hard coded.
When adding new functionality to the admin login, it may be necessary to show own messages instead of the "Wrong Username/Password",