More config-records are selected than it should

[JaroslavHerber]

The "%" in the LIKE-statement selects more config-records than it should.
For example, if you have 2 themes "mytheme" and "mytheme-mobile" and lets say "mytheme" is the active one, this query selects all configs from both themes, because LIKE "mytheme%" also matches "mytheme-mobile".
Whats the purpose of this "%" anyway?

[realFlowControl]

Hey @JaroslavHerber,
thanks for taking the time to make this PR. We will discuss this with the team, why we have this LIKE condition there. In the mean time, could you cleanup this a bit more?

• as we do not use the% anymore, it should not be a LIKE but an =
• considering this, we might not need that if else-block at all anymore and could just add that to the where-condition in line

  oxideshop_ce/source/Core/Config.php

  Line 565 in 0863e20

  where oxshopid = :oxshopid and ";

• and we could also move the binding of the $module parameter up to line

  oxideshop_ce/source/Core/Config.php

  Line 559 in 0863e20

  $params = [

What do you think about this?

/Florian

[JaroslavHerber]

Hey @flow-control,

thank you for your comment. Meanwhile I figured out, why the "%" is there. It's because of this const:
const OXMODULE_MODULE_PREFIX = 'module:';

.. which is used in init() to select and load all module-configs at once:
// loading modules config
$this->_loadVarsFromDb($shopID, null, Config::OXMODULE_MODULE_PREFIX);

I'll reconsider a better solution...

Best regards, Jaro

[realFlowControl]

Hey @JaroslavHerber,

we will run this branch through our internal CI and merge if everything is green.
FYI: our internal CI system also runs unit/integration tests with PE and EE editions and several modules installed, as well as Codeception tests.

/Flo

[realFlowControl]

Hey @JaroslavHerber,

just an update for you: I rebased your pull request on latest master and fixed some minor coding style issues. Also this should fix some tricky issues in travis. Lets hope for the best 🤞

/Flo

[realFlowControl]

Hello @JaroslavHerber,

thank you very much, internal CI is also 💚, just merged everything.

/Flo

[JaroslavHerber]

Hi @flow-control ,

thats awesome. Thank you very much :)

Best regards,
Jaro