Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1235 angr on android #1351

Merged
merged 20 commits into from
Jul 23, 2019
Merged

1235 angr on android #1351

merged 20 commits into from
Jul 23, 2019

Conversation

commjoen
Copy link
Collaborator

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR covers issue #1235 .

@OMTGreleaser
Copy link
Collaborator

Results for commit da59793: Broken link result: [!] Error(s) found by the Links validator: 4 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

@commjoen commjoen changed the title 1235 ang on android (WIP) 1235 angr on android (WIP) Jul 22, 2019
@OMTGreleaser
Copy link
Collaborator

Results for commit edd00b3: Broken link result: [!] Error(s) found by the Links validator: 4 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 5 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

@commjoen commjoen changed the title 1235 angr on android (WIP) 1235 angr on android Jul 23, 2019
@OMTGreleaser
Copy link
Collaborator

Results for commit 28bd141: Broken link result: [!] Error(s) found by the Links validator: 4 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

@OMTGreleaser
Copy link
Collaborator

Results for commit 16ae1c9: Broken link result: [!] Error(s) found by the Links validator: 5 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

@OMTGreleaser
Copy link
Collaborator

Results for commit 9848497: Broken link result: [!] Error(s) found by the Links validator: 5 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

cpholguera
cpholguera requested changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd say the depth is perfect, also because we already have an example. Please see the comments and suggestions :)

Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
@commjoen @cpholguera
Update Document/0x05b-Basic-Security_Testing.md
939c2c3 
Co-Authored-By: cpholguera <perezholguera@gmail.com>
@OMTGreleaser
Copy link
Collaborator

Results for commit a8bffe0: Broken link result: [!] Error(s) found by the Links validator: 6 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

commjoen and others added 5 commits July 23, 2019 08:13
@commjoen @cpholguera
Update Document/0x05b-Basic-Security_Testing.md
95959c8 
Co-Authored-By: cpholguera <perezholguera@gmail.com>
@commjoen @cpholguera
Update Document/0x05b-Basic-Security_Testing.md
19768da 
Co-Authored-By: cpholguera <perezholguera@gmail.com>
@commjoen @cpholguera
Update Document/0x05b-Basic-Security_Testing.md
fa1ecbe 
Co-Authored-By: cpholguera <perezholguera@gmail.com>
@commjoen @cpholguera
Update Document/0x05b-Basic-Security_Testing.md
a416e5e 
Co-Authored-By: cpholguera <perezholguera@gmail.com>
@commjoen @cpholguera
Update Document/0x05b-Basic-Security_Testing.md
77bd584 
Co-Authored-By: cpholguera <perezholguera@gmail.com>
@OMTGreleaser
Copy link
Collaborator

Results for commit 18fb7f4: Broken link result: [!] Error(s) found by the Links validator: 5 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

@OMTGreleaser
Copy link
Collaborator

Results for commit a07a5f8: Broken link result: [!] Error(s) found by the Links validator: 5 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

cpholguera
cpholguera requested changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new suggestion that fixes typo and adds hint on formal methods

Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
@commjoen @cpholguera
Update Document/0x05b-Basic-Security_Testing.md
2a9c726 
fix ondouble wording

Co-Authored-By: cpholguera <perezholguera@gmail.com>
@OMTGreleaser
Copy link
Collaborator

Results for commit 24acabf: Broken link result: [!] Error(s) found by the Links validator: 5 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

TheDauntless
TheDauntless requested changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
cpholguera
cpholguera approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@OMTGreleaser
Copy link
Collaborator

Results for commit 85595bc: Broken link result: [!] Error(s) found by the Links validator: 5 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

@commjoen commjoen merged commit 9080126 into master Jul 23, 2019
@commjoen commjoen deleted the 1235-ang-on-android branch July 23, 2019 15:30
@commjoen commjoen mentioned this pull request Jul 23, 2019
Closed
6 tasks
@OMTGreleaser
Copy link
Collaborator

Results for commit fa9f9e3: Broken link result: [!] Error(s) found by the Links validator: 5 pages have dead links! Verbose output in /link-check-result.out .
Please run the Apply_Link_Check.sh in the tools folder to see wherhe the Link issues are.
Markdown result errorlength: 1 ../linter-result.out .
Please run the Apply_Linter_check.sh in the tools folder to see where the Lint issues are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDauntless TheDauntless TheDauntless approved these changes

@cpholguera cpholguera cpholguera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@commjoen @OMTGreleaser @TheDauntless @cpholguera