-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add redisreplication status masterNode #849
Conversation
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #849 +/- ##
==========================================
+ Coverage 35.20% 38.08% +2.88%
==========================================
Files 19 19
Lines 3213 2649 -564
==========================================
- Hits 1131 1009 -122
+ Misses 2015 1569 -446
- Partials 67 71 +4 ☔ View full report in Codecov by Sentry. |
Hello @drivebyer :) !!! |
@wkd-woo At first glance, they may seem identical, but they actually serve different purposes. With this pull request, we can obtain the conclusion status from a custom resource without having to delve into the details of the pod. |
Thank you for your response! @drivebyer As you said, the feature I requested was a workflow in the form of diving in and out of the pod, so it took a lot of time for reconcilers to update the "master" label after failover (about 1 minute) This was too fatal to be applied in a production environment in reality. It means that HA outages take more than a minute to access a single endpoint as a service. It would be great if this PR merges. Thanks!
|
@drivebyer can we try some failover testing here and check who is the master now |
Pull request was converted to draft
Sure |
I would review it. |
@shubham-cmyk, I tested it on my local k8s setup(sentinel + replication). The status gets updated to the new master once the old master pod is killed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: add redisreplication status masterNode Signed-off-by: drivebyer <yang.wu@daocloud.io> * fix e2e Signed-off-by: drivebyer <yang.wu@daocloud.io> * fix lint Signed-off-by: drivebyer <yang.wu@daocloud.io> * fix lint Signed-off-by: drivebyer <yang.wu@daocloud.io> --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: wkd-woo <wkdwoos@gmail.com>
* feat: add redisreplication status masterNode Signed-off-by: drivebyer <yang.wu@daocloud.io> * fix e2e Signed-off-by: drivebyer <yang.wu@daocloud.io> * fix lint Signed-off-by: drivebyer <yang.wu@daocloud.io> * fix lint Signed-off-by: drivebyer <yang.wu@daocloud.io> --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Description
Add redisreplication status masterNode
Type of change
Checklist
Additional Context