Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exporter connect to custom redis port #736

Merged
merged 4 commits into from
Dec 25, 2023

Conversation

drivebyer
Copy link
Collaborator

Description

Fixes exporter connect to custom redis port

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8e8ded9) 29.37% compared to head (60a6eec) 29.32%.

Files Patch % Lines
k8sutils/statefulset.go 0.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   29.37%   29.32%   -0.06%     
==========================================
  Files          19       19              
  Lines        3176     3182       +6     
==========================================
  Hits          933      933              
- Misses       2212     2217       +5     
- Partials       31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer enabled auto-merge (squash) December 24, 2023 01:54
@shubham-cmyk shubham-cmyk merged commit 8f789aa into OT-CONTAINER-KIT:master Dec 25, 2023
25 of 27 checks passed
@drivebyer drivebyer deleted the fix-port branch December 25, 2023 07:04
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* fix port check

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

* test redis_up

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

* fix exporter env

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

* fix url

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

---------

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants