Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ENABLE_WEBHOOKS env which cloud disable webhook server locally #617

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Support ENABLE_WEBHOOKS env which cloud disable webhook server locally #617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d27cdb
Support ENABLE_WEBHOOKS env which cloud disable webhook server on loc…
drivebyer Sep 10, 2023
3d5a67f
Add related flag
drivebyer Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ func main() {
var metricsAddr string
var enableLeaderElection bool
var probeAddr string
var enableWebhooks bool
flag.BoolVar(&enableWebhooks, "enable-webhooks", os.Getenv("ENABLE_WEBHOOKS") != "false", "Enable webhooks")
flag.StringVar(&metricsAddr, "metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
flag.BoolVar(&enableLeaderElection, "leader-elect", false,
Expand Down Expand Up @@ -122,21 +124,24 @@ func main() {
setupLog.Error(err, "unable to create controller", "controller", "RedisSentinel")
os.Exit(1)
}
if err = (&redisv1beta2.Redis{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "Redis")
os.Exit(1)
}
if err = (&redisv1beta2.RedisCluster{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "RedisCluster")
os.Exit(1)
}
if err = (&redisv1beta2.RedisReplication{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "RedisReplication")
os.Exit(1)
}
if err = (&redisv1beta2.RedisSentinel{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "RedisSentinel")
os.Exit(1)

if enableWebhooks {
if err = (&redisv1beta2.Redis{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "Redis")
os.Exit(1)
}
if err = (&redisv1beta2.RedisCluster{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "RedisCluster")
os.Exit(1)
}
if err = (&redisv1beta2.RedisReplication{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "RedisReplication")
os.Exit(1)
}
if err = (&redisv1beta2.RedisSentinel{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "RedisSentinel")
os.Exit(1)
}
}
// +kubebuilder:scaffold:builder

Expand Down