Add a prefix to DEPRECATED to avoid conflit with newer esp32 arduino cores #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the hint. I have not tested arduino-esp v3 yet. Added to my todo. |
…o cores.
To avoid collision with esp32 / binary.h file DEPRECATED and compiler warnings I suggest adding a prefix MRFC_ to the define in this project.
Example warning with GCC 12:
In file included from C:/Users/pasca/.platformio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:41,
from .pio/libdeps/wokwi/RFID_MFRC522v2/src/MFRC522v2.h:18,
from .pio/libdeps/wokwi/RFID_MFRC522v2/src/MFRC522v2.cpp:2:
C:/Users/pasca/.platformio/packages/framework-arduinoespressif32/cores/esp32/binary.h:28: warning: "DEPRECATED" redefined
28 | #define DEPRECATED(x) [[deprecated("use " #x " instead")]]
|
In file included from .pio/libdeps/wokwi/RFID_MFRC522v2/src/MFRC522v2.h:13:
.pio/libdeps/wokwi/RFID_MFRC522v2/src/deprecated.h:12: note: this is the location of the previous definition
12 | #define DEPRECATED [[deprecated]]
|
409555d to
08739d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid collision with esp32 / binary.h file DEPRECATED and compiler warnings I suggest adding a prefix MRFC_ to the define in this project.
See : https://github.com/espressif/arduino-esp32/blob/c16a325439fe5a8a3160701d9601634155bb1443/cores/esp32/binary.h#L28
Example warning with GCC 12: