Remove __setattr__ from EchoData [all tests ci]

[leewujung]

EchoData.__setattr__ seems to be a legacy method that can now be removed.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (9f56124) to head (4676c99).
Report is 179 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
+ Coverage   83.52%   85.31%   +1.78%     
==========================================
  Files          64       72       +8     
  Lines        5686     6576     +890     
==========================================
+ Hits         4749     5610     +861     
- Misses        937      966      +29     

Flag	Coverage Δ
unittests	85.31% <ø> (+1.78%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leewujung]

Remove this block once #1447 is merged.

echopype/echopype/tests/echodata/test_echodata.py

Lines 275 to 292 in b181b92

	# TODO: https://github.com/OSOceanAcoustics/echopype/pull/1447
	# def test_setattr(self, converted_zarr):
	# sample_data = xr.Dataset({"x": [1, 2, 3, 4]})
	# sample_data2 = xr.Dataset({"y": [4, 5, 6]})
	#
	# ed = self.create_ed(converted_raw_path=converted_zarr)
	#
	# current_ed_beam = ed["Sonar/Beam_group1"]
	# current_ed_top = ed["Top-level"]
	#
	# ed["Top-level"] = sample_data
	# ed["Sonar/Beam_group1"] = sample_data2
	#
	# assert ed["Top-level"].equals(sample_data) is True # problem here
	# assert ed["Top-level"].equals(current_ed_top) is False
	#
	# assert ed["Sonar/Beam_group1"].equals(sample_data2) is True
	# assert ed["Sonar/Beam_group1"].equals(current_ed_beam) is False

[ctuguinay]

LGTM!