temporal: Fixed ruff errors in t.list #5063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
requested changes
Feb 7, 2025
There was a problem hiding this comment.
This is probably not the best approach, you are doubling the amount of code, see the approach used in
grass/temporal/t.rast.what/t.rast.what.py
Line 361 in 69a9b89
|
Yep, I agree with @petrasovaa here, I worked a bit to find that solution. The nullcontext is the appropriate choice for these situations, where sometimes a context manager is needed, but sometimes not, and you want to keep the "shape" of a context manager in both cases. See #4224 |
echoix
reviewed
Feb 11, 2025
There was a problem hiding this comment.
It was to resolve PTH201 in examples.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed ruff errors regarding path and context manager