r.sim: cleanup of global variables #5044
Open
+438
−635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilason
reviewed
Feb 5, 2025
cwhite911
reviewed
Feb 5, 2025
Thanks! I will look at it, maybe address some of these in a later PR. |
cwhite911
reviewed
Feb 10, 2025
There was a problem hiding this comment.
@petrasovaa are you planning on removing waterglobs.h? If not, add a comment in the file explaining it's purpose and add nice comment's to the obscure variables names.
| int maxwab; | ||
| double step, conv; | ||
| typedef struct { | ||
| double halpha; |
There was a problem hiding this comment.
Add comments explaining what these variables are.
| struct WaterParams { | ||
| double xmin, ymin, xmax, ymax; | ||
| double mayy, miyy, maxx, mixx; | ||
| typedef struct { |
There was a problem hiding this comment.
Add some comments here to document what this geometry struct is design to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to get clean up the r.sim code:
nwalkavariable)There will be more changes/fixes, but perhaps it would be good to get this merged first.