utils: Use context managers for subprocesses and opening files #4905
+37
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,8 +14,8 @@ | |||
|
|
|||
|
|
|||
| def check_md(filename): | |||
| p = subprocess.Popen(["mdl", filename]) | |||
| p.wait() | |||
| with subprocess.Popen(["mdl", filename]) as p: | |||
Check notice
Code scanning / Bandit
Starting a process with a partial executable path Note
74f057c to
9c4084b
Compare
9c4084b to
7a45fcb
Compare
petrasovaa
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out a tool called pyrefact. While not that safe and stable (hanged on some files if not changed), it still found out some places where context managers could be used and applied these transformations. The changes by pyrefact plus some manual tweaks were enough to unlock existing ruff simplifications afterwards.
I include here some changes that were appropriate for us