Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'gdal raster overview add' and 'gdal raster overview delete' #11614

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

@rouault rouault added funded through GSP Work funded through the GDAL Sponsorship Program gdal_cli Anything related to the new 3.11 "gdal" CLI frontend labels Jan 8, 2025
@rouault rouault added this to the 3.11.0 milestone Jan 8, 2025
@rouault rouault force-pushed the gdal_raster_overview branch from 9045e93 to ac7f7a0 Compare January 8, 2025 22:54
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.083% (+0.009%) from 70.074%
when pulling ac7f7a0 on rouault:gdal_raster_overview
into 196f855 on OSGeo:master.

@rouault
Copy link
Member Author

rouault commented Jan 15, 2025

@jratike80 @sgillies Thoughts ?

@jratike80
Copy link
Collaborator

Thoughts ?

  • I have always been thinking that -ro in gdaladdo is a programmer's view, but for a user it means external overviews. Would it be dangerous to have gdal raster overview add --external instead, even it is not explicit - overviews can be external for non-tiff formats anyway.
  • What is the meaning of --read-only with gdal raster overview delete? To delete the overviews if they are external, but not if they are internal, or?
  • "Integral overview levels" feel somehow odd but my English is not so good that I could tell why.

@rouault rouault force-pushed the gdal_raster_overview branch from ac7f7a0 to f5e058e Compare January 15, 2025 15:32
@rouault
Copy link
Member Author

rouault commented Jan 15, 2025

@jratike80 Thanks for the feedbak. "--read-only" renamed to "--external" to both "add" and "remove". "Integral..." rephrased to "A list of overview levels to build. Each overview level must be an integer value greater or equal to 2."

@rouault rouault force-pushed the gdal_raster_overview branch from f5e058e to 6a8bf81 Compare January 15, 2025 16:36
@rouault rouault merged commit a66da76 into OSGeo:master Jan 16, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program gdal_cli Anything related to the new 3.11 "gdal" CLI frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants