Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the EDK2 toolchain and QEMU invoking commands #464

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Update the EDK2 toolchain and QEMU invoking commands #464

merged 2 commits into from
Mar 18, 2021

Conversation

xiangmy
Copy link
Contributor

@xiangmy xiangmy commented Mar 18, 2021 •
edited
Loading

As discussed in OP-TEE/manifest#179

  • Older EDK2 toolchains (GCC49) will cause errors when updating EDK2, therefore, we use GCC5 instead.
  • QEMU has adopted meson as the build system. As a result, the output of QEMU will be located in the $(QEMU_PATH)/build, so we should reflect this change.

@xiangmy xiangmy mentioned this pull request Mar 18, 2021
Open
jforissier
jforissier requested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Please create one commit for the EDK2 update and one for QEMU and see below.

qemu.mk Outdated Show resolved Hide resolved
@jforissier
Copy link
Contributor

For commit "Update the EDK2 toolchain":
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Tested-by: Jerome Forissier <jerome@forissier.org> (QEMUv8)

@jforissier
Copy link
Contributor

For commit "Update QEMU invoking commands":
Please add prefix: "qemu, qemu_v8: update QEMU invoking commands". With that:
Reviewed-by: Jerome Forissier <jerome@forissier.org>

Please also add my review/test tags.

xiangmy added 2 commits March 18, 2021 17:21
@xiangmy
qemu, qemu_v8: update QEMU invoking commands
a2e3107 
QEMU has adopted meson as the build system. As a result, the output of QEMU will
be located in the $(ROOT)/qemu/build, so we should reflect this change.

Signed-off-by: Mingyuan Xiang <xiang_my@outlook.com>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
@xiangmy
qemu_v8: Update the EDK2 toolchain
88d7215 
Older EDK2 toolchains (GCC49) will cause errors when updating EDK2, therefore,
we use GCC5 instead.

Signed-off-by: Mingyuan Xiang <xiang_my@outlook.com>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Tested-by: Jerome Forissier <jerome@forissier.org> (QEMUv8)
@xiangmy
Copy link
Contributor Author

xiangmy commented Mar 18, 2021

Made the changes, thanks!

@jforissier jforissier merged commit 55b3964 into OP-TEE:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jforissier jforissier jforissier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangmy @jforissier