Database resilience #143
Merged
Database resilience #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry database connection on DatabaseError every 2s for up to 30s. This allows the app to be more robust when starting up. For instance when running up apps via docker-compose the app should be able to recover if the database is not up first.
jcox-dev
suggested changes
Feb 16, 2018
secure_message/application.py
Outdated
| @retry(retry_on_exception=retry_if_database_error, wait_fixed=2000, stop_max_delay=30000, wrap_exception=True) | ||
| def create_db(app, app_config): | ||
| database.db.init_app(app) | ||
| logger.info('Starting Secure Message Service...', config=app_config) |
There was a problem hiding this comment.
This log line can probably live outside of the create_db function.
jcox-dev
approved these changes
Feb 19, 2018
|
@JamesGardiner Fair point. There is this rholder/retrying#72 and https://travis-ci.org/rholder/retrying/builds/287235053?utm_source=github_status&utm_medium=notification. I have left a comment on the PR to see if it could be moved forward but whether we want to use it without 3.6 in the travis test matrix on master yet is the question? |
|
@benjefferies considering it has had a green build will approve for now. |
JamesGardiner
approved these changes
Feb 19, 2018
AndrewTorrance
pushed a commit
that referenced
this pull request
Feb 19, 2018
* master: Database resilience (#143) # Conflicts: # Pipfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Link to Trello card
Adding retry mechanism for when service is up before database. It means that the service will try every 2 seconds for 30 seconds to connect
How to review
Run service without database, start database after a few seconds and it should connect