Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Code - Change parameter naming convention #76

Closed
MagdalenaLarge opened this issue Jul 11, 2024 · 1 comment
Closed

Access Code - Change parameter naming convention #76

MagdalenaLarge opened this issue Jul 11, 2024 · 1 comment
Labels
Refine To be refined

Comments

@MagdalenaLarge
Copy link

MagdalenaLarge commented Jul 11, 2024

As Software Engineer
I want to have a consistent way of naming parameters
So that the user of the Design System can easier navigate our components

Description
We have inconsistent approach to naming parameters.
When dealing with a component that has a some text and a href (nav, service nav, language etc) we don't use the same name conventions. Navigation uses title and path and service navigation uses text and url.
We need to review and update so we use consistent parameters names.

For Access Code we currently have

  • postTextboxLinkText
  • postTextboxLinkUrl

Acceptance Criteria

  1. Naming convention to this component has been agreed within Dev team.
  2. Naming convention has been applied to the component.

Visualisation/Input from UCD
How should the components look like?

Linked User stories/epics
Outcome of the spike

Technical details (optional)
MVP (optional)

@MagdalenaLarge MagdalenaLarge added the Refine To be refined label Jul 11, 2024
@MagdalenaLarge MagdalenaLarge changed the title Access Code - Change naming keys convention Access Code - Change parameter naming convention Jul 11, 2024
@rmccar
Copy link

rmccar commented Jul 19, 2024

After reviewing decided to make no changes to the component

@rmccar rmccar closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refine To be refined
Projects
None yet
Development

No branches or pull requests

2 participants